Handle compilation exiting #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for compilation to exit, and we were not handling it properly. This was complicated by the fact that builds happen inside a GenServer, so wrapping things in a try/rescue with an exit handler wasn't enough. Instead, i launched another process that's monitored and awaited by the build genserver. Then any DOWN messages are turned into diagnostics, and reported. Fixes #504
zachallaun
approved these changes
Dec 12, 2023
apps/remote_control/lib/lexical/remote_control/build/document.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/build/document.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/build/project.ex
Outdated
Show resolved
Hide resolved
|
Obviously look into the test errors but the strategy looks good to me. |
Implemented some of the PR suggestions, and increased the global timeout for assert_receive to 1 second to see if that fixes errors in CI
* Excluded a test that relied on elixir >= 1.14.0 on elixir 1.13 * Used Process.demonitor rather than a receive block to flush down message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for compilation to exit, and we were not handling it properly. This was complicated by the fact that builds happen inside a GenServer, so wrapping things in a try/rescue with an exit handler wasn't enough.
Instead, i launched another process that's monitored and awaited by the build genserver. Then any DOWN messages are turned into diagnostics, and reported.
Fixes #504